Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase bitness in test/fixtures/*.pem #3659

Merged
merged 1 commit into from
Oct 1, 2024
Merged

test: increase bitness in test/fixtures/*.pem #3659

merged 1 commit into from
Oct 1, 2024

Conversation

LiviaMedeiros
Copy link
Contributor

Avoid test failures with ERR_SSL_EE_KEY_TOO_SMALL error.

mcollina
mcollina approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Uzlopak
Uzlopak approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit e04abdd into nodejs:main Oct 1, 2024
31 of 32 checks passed
flakey5 pushed a commit to flakey5/undici that referenced this pull request Oct 8, 2024
@LiviaMedeiros @flakey5
test: increase bitness in test/fixtures/*.pem (nodejs#3659)
85824f0
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiviaMedeiros @mcollina @Uzlopak